Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSIM-1155: Update DDF metrics / metric_subsets #411

Merged
merged 21 commits into from
Jun 17, 2024
Merged

OPSIM-1155: Update DDF metrics / metric_subsets #411

merged 21 commits into from
Jun 17, 2024

Conversation

rhiannonlynne
Copy link
Member

In preparation for making a summary for the DDF working group, this PR

  • changes the name of "metric_set" to "metric_subset"
  • adds a Coaddm5PerNight metric
  • supports UniSlicers being run with metrics which return a Histogram (object) value (because UniSlicers automatically have IdentityMetric added in order to add results to the summary database)
  • Allows UniSlicers to carry slicePoint information (such as identifying the RA/Dec of a DDF location)
  • Modifies an option for plotting with the OneDSlicer to permit accurate plotting of data with filled data values
  • Quiets voluminous warnings about bin size from the "automatic bin size calculation utility"
  • Updates DDF metrics to add CoaddM5PerNight. Also modifies some other cadence 'per night' metrics to run "Per DDF" instead of "at the center of the DDF" (i.e. using a UniSlicer + sql constraint, instead of UserPointSlicer at the center of the DDF).

@rhiannonlynne
Change the name 'metric_set' to 'metric_subsets'
f1a5b6b
@rhiannonlynne
Add convenience functions to make a wfd and circular healpix subset s…
5778c48 
…licer
@rhiannonlynne
Remove unused dictionary/print functions
7f746cb
@rhiannonlynne
Line length and doc string format.
392acf5
@rhiannonlynne
Export 'coadd_m5' and only print (common) warning with verbose flag
136d12b
@rhiannonlynne
Only print (common) warnings with verbose flag
8479bda
@rhiannonlynne
Let unislicer carry "slicepoint" information if needed.
ba0b791
@rhiannonlynne
Change how "filled" flag works
6b56cf3 
Instead of trying to make a filled bar plot (which wasn't actually used), now "filled_data" fills the metric_values with their fill value (instead of only allowing masking).
@rhiannonlynne
Add coadd-per-night metric (intended for DDFs primarily)
265f9d8
@rhiannonlynne
Line length and doc string format.
f8dcf88
@rhiannonlynne
Sort of a hack to allow the "Identity" metric automatically applied t…
c70b18a 
…o UniSlicer metrics to not fail when metric returns a histogram (ie. for the SummaryHistogram plotter).
@rhiannonlynne
Update the DDF metric batch.
4158197 
NvisitsPerNight now works on Unislicer (receiving all visits per DDF, not just those at the center). Added CoaddPerNight metric. Fixed SeasonLength plot labels.
@rhiannonlynne
Copy link
Member Author

I guess this is likely to fail unit tests until we make a new tag for rubin_scheduler (to add the "get_current_footprint" function)

@rhiannonlynne
Copy link
Member Author

Ok - I needed to update the data download for MAF to add the metric_subsets.json file and a small h5 summary stat test file.
At the same time, I added the data file for Eli's photometric calibration metric, so that'll be the next PR I think.
Rubin-scheduler has been tagged so the get_current_footprint utility should be available.
Let's see if there's anything else missing between dev and this environment.

yoachim
yoachim approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@yoachim yoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all reasonable.

Seems like there's a tests_2024_04_23.tgz file that got created but isn't being used. We should update to using that one or delete it off sdf to avoid confusion.

@rhiannonlynne
Copy link
Member Author

Thanks - I thought the tests had been updated at some point, but I was just going with what was in the previous dictionary. Will update the tests to use the new version (which just drops the skybrightnessPre files from the tests directory) and double-check.

@rhiannonlynne rhiannonlynne merged commit 1b55750 into main Jun 17, 2024
6 of 9 checks passed
@rhiannonlynne rhiannonlynne deleted the tickets/OPSIM-1155 branch June 17, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoachim yoachim yoachim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhiannonlynne @yoachim